fix(rules): shield of faith grants its SRD deflection AC buff (+2, +1 per six caster levels, max +5) via a new BuffEffect flat scaling
This commit is contained in:
@@ -61,33 +61,66 @@ class TestGoldenCombats:
|
||||
|
||||
Golden updated by the Weapon Focus conformance fix: the feat filter
|
||||
"Pistol" now matches her pistol names ("... (pistolet ?)"), so every
|
||||
pistol attack gains the +1 feat bonus. Line-by-line:
|
||||
- rounds 1-3: unchanged (Bull's Strength casts, goblin misses).
|
||||
- round 4 tammara: total 15 -> 16 (the +1 Weapon Focus), AC 16 is now
|
||||
met: MISS -> HIT 17 damage, goblin 6 -> -11 (below its -CON death
|
||||
threshold).
|
||||
- "goblin down" + "players win in 4 rounds": the goblin dies on round
|
||||
4, so the old rounds 4-10 goblin shots and the draw are gone.
|
||||
pistol attack gains the +1 feat bonus.
|
||||
|
||||
Updated again by the SRD shield-of-faith fix (data/spells/
|
||||
shield_of_faith.json now carries its real +2 deflection AC buff):
|
||||
_find_buff_spell returns the FIRST buff spell in her known-spell
|
||||
order, and Shield of Faith (list index 30) precedes Bull's Strength
|
||||
(index 46) — so the policy's buff pick is now Shield of Faith.
|
||||
Line-by-line:
|
||||
- rounds 1-4 tammara: "cast Shield of Faith ... DC14 SAVED -> buff 1
|
||||
mods (10r)" — DC 14 = 10 + spell level 1 + her +3 Wis; the deflection
|
||||
buff does not stack with itself, so the re-casts just refresh it. She
|
||||
has four level-1 slots, so the buff phase now runs rounds 1-4 (the
|
||||
old Bull's Strength phase ran rounds 1-3 on three level-2 slots).
|
||||
- rounds 1-10 goblin: "AC 22" (was 20) — the +2 deflection raises her
|
||||
AC; the goblin's d20=15+4-2=17 shot still misses.
|
||||
- rounds 5-10 tammara: "d20=10+9-6=14 AC 16 -> MISS" — out of level-1
|
||||
slots she shoots; without Bull's Strength's +2 enhancement attack
|
||||
bonus the scripted d20=10 shot totals 14, below the goblin's AC 16.
|
||||
- "battle over: draw after 10 rounds": the goblin is never dropped
|
||||
within the round cap. This is a default_policy first-match heuristic
|
||||
artifact (Shield of Faith is a legitimate SRD buff, just a
|
||||
defensively-picked one), not an SRD regression.
|
||||
"""
|
||||
result, _ = run_golden("tammara")
|
||||
assert result.winner == "players"
|
||||
assert result.rounds == 4
|
||||
assert result.winner is None
|
||||
assert result.rounds == 10
|
||||
assert result.transcript == (
|
||||
"initiative: tammara d20=15+7=22",
|
||||
"initiative: goblin d20=10+6=16",
|
||||
("round 1 tammara: cast Bull's Strength vs tammara DC15 SAVED -> buff 3 mods (60r) "
|
||||
"(36->36)"),
|
||||
"round 1 goblin: short bow vs tammara d20=15+4-2=17 AC 20 -> MISS",
|
||||
("round 2 tammara: cast Bull's Strength vs tammara DC15 SAVED -> buff 3 mods (60r) "
|
||||
"(36->36)"),
|
||||
"round 2 goblin: short bow vs tammara d20=15+4-2=17 AC 20 -> MISS",
|
||||
("round 3 tammara: cast Bull's Strength vs tammara DC15 SAVED -> buff 3 mods (60r) "
|
||||
"(36->36)"),
|
||||
"round 3 goblin: short bow vs tammara d20=15+4-2=17 AC 20 -> MISS",
|
||||
("round 4 tammara: Braises d'Automne (pistolet ?) vs goblin d20=10+9-6=16 "
|
||||
"AC 16 -> HIT 17 damage (6->-11)"),
|
||||
"round 4 tammara: goblin down",
|
||||
"battle over: players win in 4 rounds",
|
||||
("round 1 tammara: cast Shield of Faith vs tammara DC14 SAVED "
|
||||
"-> buff 1 mods (10r) (36->36)"),
|
||||
"round 1 goblin: short bow vs tammara d20=15+4-2=17 AC 22 -> MISS",
|
||||
("round 2 tammara: cast Shield of Faith vs tammara DC14 SAVED "
|
||||
"-> buff 1 mods (10r) (36->36)"),
|
||||
"round 2 goblin: short bow vs tammara d20=15+4-2=17 AC 22 -> MISS",
|
||||
("round 3 tammara: cast Shield of Faith vs tammara DC14 SAVED "
|
||||
"-> buff 1 mods (10r) (36->36)"),
|
||||
"round 3 goblin: short bow vs tammara d20=15+4-2=17 AC 22 -> MISS",
|
||||
("round 4 tammara: cast Shield of Faith vs tammara DC14 SAVED "
|
||||
"-> buff 1 mods (10r) (36->36)"),
|
||||
"round 4 goblin: short bow vs tammara d20=15+4-2=17 AC 22 -> MISS",
|
||||
("round 5 tammara: Braises d'Automne (pistolet ?) vs goblin "
|
||||
"d20=10+9-6=14 AC 16 -> MISS"),
|
||||
"round 5 goblin: short bow vs tammara d20=15+4-2=17 AC 22 -> MISS",
|
||||
("round 6 tammara: Braises d'Automne (pistolet ?) vs goblin "
|
||||
"d20=10+9-6=14 AC 16 -> MISS"),
|
||||
"round 6 goblin: short bow vs tammara d20=15+4-2=17 AC 22 -> MISS",
|
||||
("round 7 tammara: Braises d'Automne (pistolet ?) vs goblin "
|
||||
"d20=10+9-6=14 AC 16 -> MISS"),
|
||||
"round 7 goblin: short bow vs tammara d20=15+4-2=17 AC 22 -> MISS",
|
||||
("round 8 tammara: Braises d'Automne (pistolet ?) vs goblin "
|
||||
"d20=10+9-6=14 AC 16 -> MISS"),
|
||||
"round 8 goblin: short bow vs tammara d20=15+4-2=17 AC 22 -> MISS",
|
||||
("round 9 tammara: Braises d'Automne (pistolet ?) vs goblin "
|
||||
"d20=10+9-6=14 AC 16 -> MISS"),
|
||||
"round 9 goblin: short bow vs tammara d20=15+4-2=17 AC 22 -> MISS",
|
||||
("round 10 tammara: Braises d'Automne (pistolet ?) vs goblin "
|
||||
"d20=10+9-6=14 AC 16 -> MISS"),
|
||||
"round 10 goblin: short bow vs tammara d20=15+4-2=17 AC 22 -> MISS",
|
||||
"battle over: draw after 10 rounds",
|
||||
)
|
||||
|
||||
def test_tammara_vs_lich(self):
|
||||
@@ -98,6 +131,13 @@ class TestGoldenCombats:
|
||||
missiles (16 + 11 + 16 = 43) drop Tammara below 0 hp on round 1; the
|
||||
remaining two are lost (the engine's target-drops-mid-sequence
|
||||
convention), so the lich wins in 1 round.
|
||||
|
||||
Updated by the SRD shield-of-faith fix: her round-1 buff pick is now
|
||||
Shield of Faith (first buff spell in her known-spell order, index 30
|
||||
before Bull's Strength's 46) — "cast Shield of Faith ... DC14 SAVED ->
|
||||
buff 1 mods (10r)" (DC 14 = 10 + level 1 + her +3 Wis). Magic Missile
|
||||
auto-hits and ignores the +2 deflection it would otherwise grant, so
|
||||
the lich's line and the outcome are unchanged.
|
||||
"""
|
||||
result, _ = run_golden("tammara", "lich")
|
||||
assert result.winner == "monsters"
|
||||
@@ -105,8 +145,8 @@ class TestGoldenCombats:
|
||||
assert result.transcript == (
|
||||
"initiative: tammara d20=15+7=22",
|
||||
"initiative: lich d20=10+6=16",
|
||||
("round 1 tammara: cast Bull's Strength vs tammara DC15 SAVED -> buff 3 mods (60r) "
|
||||
"(36->36)"),
|
||||
("round 1 tammara: cast Shield of Faith vs tammara DC14 SAVED "
|
||||
"-> buff 1 mods (10r) (36->36)"),
|
||||
"round 1 lich: cast Magic Missile vs tammara DC16 NO SAVE -> 43 damage (36->-7)",
|
||||
"battle over: monsters win in 1 rounds",
|
||||
)
|
||||
|
||||
Reference in New Issue
Block a user