fix(rules): divine favor grants its SRD luck bonus on attack and weapon damage (+1 per three caster levels, max +3) for 1 minute

data/spells/divine_favor.json

@@ -6,6 +6,16 @@
   "save": "none",
   "base_dc": 10,
   "cast_time": "standard",
-  "effects": [],
-  "description": "You draw upon divine power for 1 round/level: a +1 luck bonus on attack rolls and weapon damage per 4 caster levels. Simplified: the engine has no luck-bonus self-buff that preserves the pinned default-policy casting order, so no mechanical effect is applied."
+  "effects": [
+    {
+      "type": "buff",
+      "modifiers": [
+        { "target": "attack", "value": 1, "bonus_type": "luck" },
+        { "target": "damage", "value": 1, "bonus_type": "luck" }
+      ],
+      "duration_rounds": 10,
+      "scaling_flat": { "amount": 1, "per_levels": 3, "max": 2 }
+    }
+  ],
+  "description": "SRD spells/divine-favor.md: evocation, level 1 (cleric/inquisitor/oracle/paladin/warpriest), range personal, duration 1 minute. You gain a +1 luck bonus on attack and weapon damage rolls, +1 for every three caster levels (at least +1, maximum +3). The bonus does not apply to spell damage - the engine's 'damage' modifier target only rides weapon damage rolls, so that clause holds by construction. Duration 1 minute = 10 rounds."
 }