ctan a9b33e4055 fix(rules): apply the spell combat penalty to the spell attack ...

PF1e (CRB Magus Spell Combat): "any attack roll made as part of this
spell also takes this penalty". _execute_spell_combat now threads the -2
through _cast_spell into the melee/ranged touch attack helpers, so e.g.
Shocking Grasp delivered via Spell Combat attacks at -2 too. No global
state is touched: the penalty is a keyword threaded per cast.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

2026-09-12 11:14:30 +02:00

..

__init__.py

chore: scaffold pf1e_simulator package (uv, ruff, basedpyright, pytest)

2026-08-17 22:49:50 +02:00

test_abilities.py

chore(lint): restore green gate

2026-09-04 23:02:20 +02:00

test_accuracy_rules.py

fix(rules): only total concealment blocks sneak attack

2026-09-11 23:41:06 +02:00

test_action_feedback.py

fix(rules): correct P1 PF1e conformance bugs (area saves, concentration, prone, slots, helpless, nauseated)

2026-09-10 20:52:28 +02:00

test_aid_and_run.py

fix(rules): stop a run from crossing difficult terrain

2026-09-11 22:16:54 +02:00

test_aoo_budget.py

feat(observation): expose remaining attacks of opportunity

2026-09-10 14:08:25 +02:00

test_aoo_defense.py

fix(rules): suppress attacks of opportunity through cover or total concealment

2026-09-11 23:23:11 +02:00

test_bleeding_confused.py

feat(conditions): add bleeding and confused rules

2026-09-10 18:15:35 +02:00

test_cackle.py

fix(combat): bound cackle hex extension

2026-09-04 23:02:24 +02:00

test_charge_result.py

feat(combat): expose charge failure reasons via ChargeResult

2026-09-06 10:47:36 +02:00

test_class_abilities.py

fix(rules): apply the spell combat penalty to the spell attack

2026-09-12 11:14:30 +02:00

test_cli.py

feat(cli): render --transcript output as a table

2026-09-11 13:02:31 +02:00

test_combat.py

fix(rules): stop auto-directed movement cutting corners

2026-09-12 10:48:12 +02:00

test_combatant_loader.py

chore(lint): restore green gate

2026-09-04 23:02:20 +02:00

test_concentration.py

fix(rules): correct P1 PF1e conformance bugs (area saves, concentration, prone, slots, helpless, nauseated)

2026-09-10 20:52:28 +02:00

test_conditional_modifiers.py

fix(rules): correct P1 PF1e conformance bugs (area saves, concentration, prone, slots, helpless, nauseated)

2026-09-10 20:52:28 +02:00

test_conditions_blinded_invisible.py

fix(rules): correct P2/P3 PF1e conformance bugs (flanking, touch, blinded, disabled, death, maneuvers, DR, sneak)

2026-09-10 21:45:50 +02:00

test_conditions_effects.py

fix(rules): correct P1 PF1e conformance bugs (area saves, concentration, prone, slots, helpless, nauseated)

2026-09-10 20:52:28 +02:00

test_conditions.py

feat(combat): enforce behavioral condition flags

2026-09-04 23:02:16 +02:00

test_conformance_action_economy.py

fix(rules): keep swift and free actions for staggered combatants

2026-09-11 20:59:19 +02:00

test_conformance_cast_time.py

feat(spells): honor spell cast time in the action budget

2026-09-11 14:09:58 +02:00

test_conformance_cover.py

fix(rules): pick the best target square for melee cover

2026-09-11 23:29:59 +02:00

test_conformance_energy.py

fix(rules): stop damage reduction from eating energy damage

2026-09-11 23:17:34 +02:00

test_conformance_p1.py

fix(rules): restrict nauseated creatures to a single move action

2026-09-12 09:44:53 +02:00

test_conformance_p2.py

fix(rules): apply the power attack penalty to melee touch attacks

2026-09-11 23:35:07 +02:00

test_conformance_pa.py

fix(rules): scale Power Attack for two-handed weapons and apply its CMB penalty

2026-09-11 00:19:06 +02:00

test_conformance_simple_monster_death.py

feat(cli): add --simple-monster-death option to kill monsters at hp <= 0

2026-09-11 12:48:43 +02:00

test_conformance_spellflow.py

fix(rules): require a ranged touch attack for ray spells

2026-09-11 20:19:03 +02:00

test_conformance_transcript_table.py

feat(cli): render --transcript output as a table

2026-09-11 13:02:31 +02:00

test_cover_levels.py

feat(combat): support partial and improved cover levels

2026-09-10 11:32:08 +02:00

test_creature_sizes.py

fix(rules): scale the bull rush push distance with the margin

2026-09-12 09:27:03 +02:00

test_defensive_actions.py

feat(combat): add total defense and fighting defensively

2026-09-10 12:52:47 +02:00

test_delay_action.py

fix(rules): stop delay from double-processing the turn start

2026-09-11 21:15:14 +02:00

test_determinism.py

fix(combat): channel energy targets living vs undead

2026-09-05 00:16:17 +02:00

test_dice.py

feat(combat): expose weapon reference in observation snapshot

2026-09-06 13:46:12 +02:00

test_direction.py

fix(rules): correct P2/P3 PF1e conformance bugs (flanking, touch, blinded, disabled, death, maneuvers, DR, sneak)

2026-09-10 21:45:50 +02:00

test_dirty_trick.py

fix(rules): correct P2/P3 PF1e conformance bugs (flanking, touch, blinded, disabled, death, maneuvers, DR, sneak)

2026-09-10 21:45:50 +02:00

test_dying_and_crits.py

fix(rules): stabilize a dying creature when healed

2026-09-12 10:35:44 +02:00

test_effects.py

feat(effects): add effect system with PF1e bonus stacking rules

2026-08-17 22:49:50 +02:00

test_elevation.py

feat(grid): apply elevation to movement cost and high ground

2026-09-05 16:18:56 +02:00

test_engine_fixes.py

feat(combat): add activate_power_attack action and consume Up Close and Deadly deed

2026-09-06 18:37:58 +02:00

test_exposed_squares.py

fix(rules): distinguish natural reach from reach weapons

2026-09-11 22:06:46 +02:00

test_feats.py

feat(data): wire all 55 PC feats

2026-09-04 23:02:25 +02:00

test_fly_speed.py

feat(combat): use fly speed for movement

2026-09-10 17:46:57 +02:00

test_foundry_extraction.py

feat(loaders): extend Foundry loader with feat/spell extraction

2026-08-17 22:49:50 +02:00

test_foundry_loader.py

test(foundry): point golden tests at renamed sheet files

2026-08-17 22:49:50 +02:00

test_grid.py

feat(runner): Monte Carlo runner, closed-form metrics and balance CLI

2026-08-17 22:49:50 +02:00

test_hex_aoe_dr.py

fix(combat): correct hex and AoE DCs, DR bypassed by spells

2026-09-04 23:02:22 +02:00

test_immediate_actions.py

fix(rules): consume the current turn's swift for an in-turn immediate

2026-09-12 10:00:25 +02:00

test_initiative_observation.py

feat(observation): expose initiative order and totals

2026-09-10 12:04:10 +02:00

test_lich.py

fix(data): lich fear aura, paralyzing touch, slot keys

2026-09-04 23:02:26 +02:00

test_llm_engine_capabilities.py

test(llm): demonstrate unblocked engine capabilities via observation-only policy

2026-09-10 15:56:21 +02:00

test_los.py

feat(combat): grant soft cover (+4 AC) to ranged attacks through creatures

2026-08-17 22:49:50 +02:00

test_maneuvers.py

fix(rules): stop steal from taking held weapons

2026-09-12 11:06:08 +02:00

test_map.py

feat(grid): apply elevation to movement cost and high ground

2026-09-05 16:18:56 +02:00

test_models.py

feat(models): combatant schema, Foundry sheet loader, monster JSON schema

2026-08-17 22:49:50 +02:00

test_monster_loader.py

fix(rules): distinguish natural reach from reach weapons

2026-09-11 22:06:46 +02:00

test_move_destination.py

fix(rules): stop auto-directed movement cutting corners

2026-09-12 10:48:12 +02:00

test_multi_natural_weapons.py

feat(combat): resolve all natural melee weapons in full_attack

2026-09-06 10:22:58 +02:00

test_observation_enriched.py

fix(rules): distinguish natural reach from reach weapons

2026-09-11 22:06:46 +02:00

test_observation.py

feat(combat): add serializable Observation snapshot and LLMPolicy adapter

2026-09-06 11:07:30 +02:00

test_pair_cover.py

fix(rules): distinguish natural reach from reach weapons

2026-09-11 22:06:46 +02:00

test_pair_failure_reasons.py

feat(observation): expose attack failure reasons

2026-09-10 13:57:34 +02:00

test_pc_combat_golden.py

feat(combat): use fly speed for movement

2026-09-10 17:46:57 +02:00

test_point_targeting.py

fix(rules): correct P1 PF1e conformance bugs (area saves, concentration, prone, slots, helpless, nauseated)

2026-09-10 20:52:28 +02:00

test_power_attack.py

chore(lint): restore green gate

2026-09-04 23:02:20 +02:00

test_prone_actions.py

fix(rules): correct P2/P3 PF1e conformance bugs (flanking, touch, blinded, disabled, death, maneuvers, DR, sneak)

2026-09-10 21:45:50 +02:00

test_ranged_threat.py

fix(rules): correct P2/P3 PF1e conformance bugs (flanking, touch, blinded, disabled, death, maneuvers, DR, sneak)

2026-09-10 21:45:50 +02:00

test_reach.py

fix(rules): distinguish natural reach from reach weapons

2026-09-11 22:06:46 +02:00

test_ready_action.py

feat(combat): add ready action with triggers

2026-09-10 12:39:28 +02:00

test_repair_weapon.py

fix(rules): correct P2/P3 PF1e conformance bugs (flanking, touch, blinded, disabled, death, maneuvers, DR, sneak)

2026-09-10 21:45:50 +02:00

test_retrieve_weapon.py

fix(rules): stop steal from taking held weapons

2026-09-12 11:06:08 +02:00

test_rng.py

feat(dice): seeded RNG protocol and dice notation parser

2026-08-17 22:49:50 +02:00

test_runner_spells.py

data(spells): add batch 3 of PC spell list (32 spells)

2026-09-10 19:43:07 +02:00

test_runner.py

feat(runner): Monte Carlo runner, closed-form metrics and balance CLI

2026-08-17 22:49:50 +02:00

test_saves.py

feat(combat): add saving throws (fort/ref/will, natural 1/20, effect modifiers)

2026-08-17 22:49:50 +02:00

test_size_is_baked_in.py

test(rules): lock in that size is baked into attack/AC values

2026-09-10 17:25:05 +02:00

test_smoke.py

chore: scaffold pf1e_simulator package (uv, ruff, basedpyright, pytest)

2026-08-17 22:49:50 +02:00

test_spell_area_snapshot.py

feat(observation): expose spell cast time in the snapshot

2026-09-11 14:13:13 +02:00

test_spell_registry_batch1.py

data(spells): add batch 2 of PC spell list (32 spells)

2026-09-10 19:12:57 +02:00

test_spell_registry_batch2.py

data(spells): add batch 3 of PC spell list (32 spells)

2026-09-10 19:43:07 +02:00

test_spell_registry_batch3.py

data(spells): add batch 3 of PC spell list (32 spells)

2026-09-10 19:43:07 +02:00

test_spell_resistance.py

fix(rules): correct P1 PF1e conformance bugs (area saves, concentration, prone, slots, helpless, nauseated)

2026-09-10 20:52:28 +02:00

test_spells.py

fix(spells): backfill casting times for all imported spells

2026-09-11 15:01:42 +02:00

test_summoning.py

fix(combat): summon spawns only on passable cells

2026-09-04 23:02:27 +02:00

test_touch_ac.py

fix(combat): resolve touch attacks against touch AC and firearms

2026-09-05 11:28:46 +02:00

test_weapon_selection.py

feat(combat): allow selecting the attacking weapon

2026-09-10 13:36:27 +02:00